feat(aci): Use new metric detector charts in issue details #102996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
50
to
54
| if (isDetectorLoading) { | ||
| return <MetricIssueChartPlaceholder />; | ||
| } | ||
|
|
||
| return ( | ||
| <MetricChartSection> | ||
| <MetricIssueChartContent | ||
| rule={rule} | ||
| timePeriod={timePeriod} | ||
| project={project} | ||
| incidents={incidents} | ||
| /> | ||
| </MetricChartSection> | ||
| ); | ||
| return <MetricIssueChartContent detector={detector} openPeriods={openPeriods} />; |
There was a problem hiding this comment.
Bug: Accessing detector.dataSources without a null check can cause a TypeError when useDetectorQuery is disabled.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The useDetectorQuery hook is configured with a conditional enabled flag. If detectorId is falsy or detectorDetails?.detectorType is not 'metric_alert', the query will not execute, resulting in detector being undefined. The MetricIssueChartContent component then attempts to access properties like detector.dataSources[0].queryObj.snubaQuery without a preceding null check, which triggers a TypeError and causes the application to crash.
💡 Suggested Fix
Add a null check for the detector variable before rendering MetricIssueChartContent. If detector is undefined, render a placeholder component instead.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/views/issueDetails/metricIssues/metricIssueChart.tsx#L50-L54
Potential issue: The `useDetectorQuery` hook is configured with a conditional `enabled`
flag. If `detectorId` is falsy or `detectorDetails?.detectorType` is not
`'metric_alert'`, the query will not execute, resulting in `detector` being `undefined`.
The `MetricIssueChartContent` component then attempts to access properties like
`detector.dataSources[0].queryObj.snubaQuery` without a preceding null check, which
triggers a `TypeError` and causes the application to crash.
Did we get this right? 👍 / 👎 to inform future reviews.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| /> | ||
| </MetricChartSection> | ||
| ); | ||
| return <MetricIssueChartContent detector={detector} openPeriods={openPeriods} />; |
Contributor
There was a problem hiding this comment.
Bug: Safeguard against missing detector data crashes.
The detector might be undefined when passed to MetricIssueChartContent because the query can be disabled (enabled: false when detectorId is missing or detectorType is incorrect), causing the component to crash when attempting to access detector.dataSources[0] in useMetricDetectorChart. The code only checks isDetectorError and isDetectorPending but doesn't validate that detector is defined before rendering.
scttcper
approved these changes
Nov 10, 2025
malwilley
deleted the
malwilley/feat/use-new-metric-detector-charts-in-issue-details
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue details page for metric issues was still using the old charts which used the old incidents model. Issues made with new detectors would not have that data. Plus, we have updated charts that we want to use on this page.
While doing this, I refactored the metric alert chart to export
useMetricDetectorChart()which makes the data fetching queries and returns the chart props. That way issue details and the detector page can reuse that logic while still rendering the loading/error states differently.Before (chart did not load because incidents model does not exist):
After: