-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(dashboards): add async queuer to dashboard widget requests #103072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DominikB2014
wants to merge
6
commits into
master
Choose a base branch
from
dominikbuszowiecki/browse-107-snuba-timeouts-from-dashboards
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(dashboards): add async queuer to dashboard widget requests #103072
DominikB2014
wants to merge
6
commits into
master
from
dominikbuszowiecki/browse-107-snuba-timeouts-from-dashboards
+207
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 7 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
TkDodo
reviewed
Nov 10, 2025
Member
|
🤔 makes sense to me so far; a few notes
👍🏻 cool stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchDatawithin each query widget, we add the query widget itself to a queuewidget.fetchData()when it's next in queue.Two things i'm iffy about
thisinto the queuer to fetch the data, it works so maybe it's fine.Also it seems like the queue is indeed processing the items, but it's not waiting between them so perhaps there's something up with the data fetching promise resolving early^ This is because i was testing with
concurrency = 1,when i set it to 2 everything worked as expected.