test(deletions): add issue platform group deletion test back

[yuvmen]

taking over #102503

[sentry]

Bug: The select_rows() method hardcodes Dataset.IssuePlatform.value, failing to dynamically select the correct dataset based on the provided entity.
_{Severity: HIGH | Confidence: 1.00}

🔍 Detailed Analysis

The select_rows() method in tests/sentry/deletions/test_group.py hardcodes dataset=Dataset.IssuePlatform.value for all queries. This ignores the entity parameter, leading to incorrect data retrieval when EntityKey.Events.value is passed. Error events, which correspond to EntityKey.Events.value, must be queried from Dataset.Events.value. This mismatch will cause queries for error events to return no results or incorrect results, leading to assertion failures in tests like line 467.

💡 Suggested Fix

Modify select_rows() to map the entity parameter to the correct dataset. If entity is EntityKey.Events.value, use Dataset.Events.value; otherwise, use Dataset.IssuePlatform.value for EntityKey.IssuePlatform.value.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: tests/sentry/deletions/test_group.py#L441-L501

Potential issue: The `select_rows()` method in `tests/sentry/deletions/test_group.py`
hardcodes `dataset=Dataset.IssuePlatform.value` for all queries. This ignores the
`entity` parameter, leading to incorrect data retrieval when `EntityKey.Events.value` is
passed. Error events, which correspond to `EntityKey.Events.value`, must be queried from
`Dataset.Events.value`. This mismatch will cause queries for error events to return no
results or incorrect results, leading to assertion failures in tests like line 467.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[cursor]

Bug: Incorrect Group Type Causes Batching Failure

The test sets the Group type field to GroupCategory.FEEDBACK (value 6), but the Group model's type field expects a group type ID, not a category. This should be FeedbackGroup.type_id (value 6001) to properly represent a feedback issue type. Using the category value instead will likely cause the batching logic being tested to fail or behave incorrectly since it won't match actual feedback groups.

tests/sentry/deletions/test_group.py#L512-L516

sentry/tests/sentry/deletions/test_group.py

Lines 512 to 516 in a0f6558

	# Set times_seen for each group
	Group.objects.filter(id=group1.id).update(times_seen=3, type=GroupCategory.FEEDBACK)
	Group.objects.filter(id=group2.id).update(times_seen=1, type=GroupCategory.FEEDBACK)
	Group.objects.filter(id=group3.id).update(times_seen=3, type=GroupCategory.FEEDBACK)
	Group.objects.filter(id=group4.id).update(times_seen=3, type=GroupCategory.FEEDBACK)

 

---

[cvxluo]

the test seems to be identical to the one removed in #102354, do we know what was causing it to fail?

[yuvmen]

armen mentions it on the PR this is copied from, this should be fixed after #102369, opened a new PR becuse

1. I want Armen to be able to approve it after I took over
2. the other PR has a bunch of my attempts to refactor and get fancy which I am pulling back from

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #103075      +/-   ##
===========================================
+ Coverage   78.24%    80.64%   +2.39%     
===========================================
  Files        9200      9205       +5     
  Lines      392932    393467     +535     
  Branches    24992     24992              
===========================================
+ Hits       307461    317312    +9851     
+ Misses      85045     75729    -9316     
  Partials      426       426