Skip to content

Conversation

@Zylphrex
Copy link
Member

This type was added as a clutch at the time but doesn't seem necessary anymore.

This type was added as a clutch at the time but doesn't seem necessary anymore.
@Zylphrex Zylphrex requested a review from a team as a code owner November 28, 2025 17:24
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 28, 2025
@Zylphrex Zylphrex merged commit 4f39f56 into master Dec 1, 2025
67 checks passed
@Zylphrex Zylphrex deleted the txiao/ref/remove-any-resolved-type branch December 1, 2025 14:30
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/snuba/rpc_dataset_common.py 84.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #104130   +/-   ##
========================================
  Coverage   80.60%    80.60%           
========================================
  Files        9326      9326           
  Lines      398408    398418   +10     
  Branches    25469     25469           
========================================
+ Hits       321127    321137   +10     
  Misses      76828     76828           
  Partials      453       453           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants