feat(onboarding): frontend for disableMemberInvite flag #76085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 7.0kB ⬆️
|
| @@ -91,6 +91,16 @@ const formGroups: JsonFormObject[] = [ | |||
| label: t('Open Membership'), | |||
There was a problem hiding this comment.
Now that you're here, can you change this to Open Team Membership? The title is confusing and makes it look like open org membership.
Comment on lines
41
to
44
| can_invite: | ||
| organization.access?.includes('member:write') || | ||
| (organization.features.includes('members-invite-teammates') && | ||
| organization.allowMemberInvite), |
There was a problem hiding this comment.
Can you move this logic to a function so then you can share code with line 53?
|
Can you please add a screenshot for what others will see who are not org admins? |
ameliahsu
force-pushed
the
mia/invite-members/fe
branch
from
228bf06
to
8284fa4
Compare
sentaur-athena
approved these changes
Aug 26, 2024
| function canInvite(organization: Organization) { | ||
| return ( | ||
| organization.access?.includes('member:write') || | ||
| (organization.features.includes('members-invite-teammates') && |
There was a problem hiding this comment.
Suggested change
| (organization.features.includes('members-invite-teammates') && | |
| (organization.access?.includes('member:invite') && organization.features.includes('members-invite-teammates') && |
|
I'm not sure if you like to add this change to this PR or the next one, but commented any ways. Looks good otherwise. |
ameliahsu
force-pushed
the
mia/invite-members/fe
branch
from
8284fa4
to
501ef18
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #76085 +/- ##
==========================================
- Coverage 78.15% 78.15% -0.01%
==========================================
Files 6903 6905 +2
Lines 307221 307228 +7
Branches 52875 52866 -9
==========================================
+ Hits 240104 240107 +3
- Misses 60705 60776 +71
+ Partials 6412 6345 -67 |
ArthurKnaus
pushed a commit
that referenced
this pull request
Aug 29, 2024
add toggle for org admin to allow/disallow members from inviting teammates to their org Admin view: <img width="1214" alt="admin_view" src="https://github.com/user-attachments/assets/610f4f67-56a4-43c2-a83c-483709057866"> Non-admin view (toggle is disabled): <img width="1216" alt="member_view" src="https://github.com/user-attachments/assets/12a990bf-6a2b-4fe3-b89d-4cb97e82df1e">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add toggle for org admin to allow/disallow members from inviting teammates to their org
Admin view:
Toggle is disabled for non-admin members and organizations that are not on a business plan:
