feat(replay): implement search bar key sections and fetch tags from IP instead of discover #76276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
| @@ -50,33 +52,69 @@ function fieldDefinitionsToTagCollection(fieldKeys: string[]): TagCollection { | |||
|
|
|||
| const REPLAY_FIELDS_AS_TAGS = fieldDefinitionsToTagCollection(REPLAY_FIELDS); | |||
| const REPLAY_CLICK_FIELDS_AS_TAGS = fieldDefinitionsToTagCollection(REPLAY_CLICK_FIELDS); | |||
| const EXCLUDED_TAGS = ['browser', 'device', 'os', 'user']; | |||
There was a problem hiding this comment.
we already have browser.name, device.name, etc. They're effectively the same
There was a problem hiding this comment.
maybe user is actually user.id, but either way they're confusing
There was a problem hiding this comment.
ohh gotcha, could we add a comment to clarify that? just for posterity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #75552. Implements sections to make the typeahead easier to navigate.
Screen recording
"Suggested" and "Click Fields" combined is = to our documented search properties: https://docs.sentry.io/concepts/search/searchable-properties/session-replay. We always want to show these.
"Tags" are tags found in the Issue Platform dataset, sorted by times seen in the dataset (popularity). Previously we were fetching these from the TagStore which queries Discover. IP has a narrower set of more relevant tags. Some more context is at #75878