feat(uptime): Extract domain and suffix from urls when creating uptime monitors #76367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wedamija
force-pushed
the
danf/uptime-extract-domain-suffix
branch
from
9ff1189
to
9ac83c9
Compare
wedamija
force-pushed
the
danf/uptime-extract-domain-suffix
branch
from
9ac83c9
to
5f548d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #76367 +/- ##
=======================================
Coverage 78.18% 78.19%
=======================================
Files 6896 6896
Lines 306552 306554 +2
Branches 50259 50259
=======================================
+ Hits 239690 239696 +6
+ Misses 60454 60452 -2
+ Partials 6408 6406 -2 |
wedamija
force-pushed
the
danf/uptime-extract-domain-suffix
branch
from
e37f71b
to
cd67e72
Compare
evanpurkhiser
approved these changes
Sep 3, 2024
wedamija
force-pushed
the
danf/uptime-extract-domain-suffix
branch
from
cd67e72
to
5f34a4e
Compare
…e monitors This uses `tldextract` to extract the domain and suffix from urls, for use in limiting number of monitors per domain, analytics and detecting anomalous failures across monitors.
wedamija
force-pushed
the
danf/uptime-extract-domain-suffix
branch
from
5f34a4e
to
ff7be87
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
tldextractto extract the domain and suffix from urls, for use in limiting number of monitors per domain, analytics and detecting anomalous failures across monitors.