fix(issues/replay): if fetchError, don't render replayId in highlights #76619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
c298lee
reviewed
Aug 27, 2024
c298lee
reviewed
Aug 27, 2024
static/app/components/events/highlights/highlightsDataSection.tsx
Outdated
Show resolved
Hide resolved
c298lee
reviewed
Aug 27, 2024
static/app/components/events/highlights/highlightsDataSection.tsx
Outdated
Show resolved
Hide resolved
michellewzhang
force-pushed
the
mz/check-fetch-error
branch
from
8757c08
to
052f806
Compare
c298lee
approved these changes
Aug 27, 2024
leeandher
approved these changes
Aug 27, 2024
| @@ -198,13 +198,19 @@ const mockGroupApis = ( | |||
| project: Project, | |||
| group: Group, | |||
| event: Event, | |||
| replayId: string | undefined, | |||
There was a problem hiding this comment.
nit: Could we make this optional instead of explicitly undefined? That way you don't have to add undefined to all the callers, only when you want to specify the trace I guess.
replayId?: string;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redo of #76316:
instead of completely removing the replay ID from the event highlights, we now do an extra check to see if there was a
fetchErrorwith this replay ID (e.g. whether this ID is actually valid or not). if it's not valid, then don't render the replay ID to avoid linking to an invalid replay. the link will take you to a page like this:before: issue details replay processing error (blue banner shows up) but the event highlights still contains the replay ID
after: replayId is shown as
--and no link