feat(alerts): Add insights metrics option and alert type #76634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
note: The alert rule builder doesn't fully work with Insight Metrics yet. This PR just includes the option and some types + constants. There will be a separate PR to update the builder to fully support Insights |
nhsiehgit
approved these changes
Aug 27, 2024
|
Thanks for the review @nhsiehgit ! This PR relies on some changes from #76566 which is still open. I based this PR on that branch to minimize the code diff. Let me know if that changes anything for you! I plan to merge this in to |
…dd-insights-metrics-option-and-alert-type
edwardgou-sentry
deleted the
egou/feat/add-insights-metrics-option-and-alert-type
branch
ArthurKnaus
pushed a commit
that referenced
this pull request
Aug 29, 2024
Adds Insights Metric as an Alert type in the UI, protected behind the `insights-alerts` feature flag.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Insights Metric as an Alert type in the UI, protected behind the
insights-alertsfeature flag.