feat(seer grouping): Add metrics for feature flag and eligible content #76639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
lobsterkatie
force-pushed
the
kmclb-add-content-and-flag-metrics-to-seer-gouping
branch
from
083fa84
to
9a7de8d
Compare
JoshFerge
approved these changes
Aug 28, 2024
trillville
approved these changes
Aug 28, 2024
lobsterkatie
deleted the
kmclb-add-content-and-flag-metrics-to-seer-gouping
branch
ArthurKnaus
pushed a commit
that referenced
this pull request
Aug 29, 2024
#76639) This adds two new metrics, `grouping.similarity.event_from_backfilled_project` and `grouping.similarity.event_content_seer_eligible`, to the helpers called in `should_call_seer_for_grouping`. In order that they both always be recorded, the order of checks there has also been rearranged, so failing one of the relevant checks doesn't prevent checking the other.
lobsterkatie
added a commit
that referenced
this pull request
Sep 4, 2024
…76895) In #76639, I added a `grouping.similarity.event_from_backfilled_project` metric, to track what percentage of events without a hash come from projects with Seer grouping turned on. Unfortunately, I forgot that the `sentry:similarity_backfill_completed` project option contains a timestamp rather than a boolean, and as a result, we've been sending a super-high-cardinality tag to DataDog. Whoops. To fix this, I obviously changed the tag value to be a boolean, but I also renamed the metric, from `event_from_backfilled_project` to `event_project_backfill_status`. This will let us just allow the problematic metric to age out, rather than worrying about selectively enabling tags for it (though I have, in fact, turned off indexing for that tag). As a bonus, it's a clearer name. (I discovered my mistake when adding a graph for the metric to our dashboard, but in that process, I had already confused myself by thinking that `event_from_backfilled_project` was only going to fire when the answer was yes.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new metrics,
grouping.similarity.event_from_backfilled_projectandgrouping.similarity.event_content_seer_eligible, to the helpers called inshould_call_seer_for_grouping. In order that they both always be recorded, the order of checks there has also been rearranged, so failing one of the relevant checks doesn't prevent checking the other.