Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): set querybuilder start/end in GroupAttributesPostgresSnubaQueryExecutor #76641

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Aug 27, 2024

Fixes SENTRY-3E15
Fixes SENTRY-3DCM
Problem this fixes: Timestamp queries to /issues/ break with internal error 500. This affects issues stream and feedback list, whether we are using the new search bar component (SearchQueryBuilder) or not.

@aliu39 aliu39 requested review from a team as code owners August 27, 2024 22:46
@aliu39 aliu39 requested a review from a team August 27, 2024 22:46
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #76641      +/-   ##
==========================================
+ Coverage   78.15%   78.18%   +0.02%     
==========================================
  Files        6910     6910              
  Lines      307183   307348     +165     
  Branches    50351    50397      +46     
==========================================
+ Hits       240075   240292     +217     
+ Misses      60753    60699      -54     
- Partials     6355     6357       +2     

Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests as well?

src/sentry/search/events/builder/discover.py Outdated Show resolved Hide resolved
aliu39 and others added 2 commits August 29, 2024 09:31
Co-authored-by: William Mak <william@wmak.io>
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliu39 aliu39 enabled auto-merge (squash) August 29, 2024 16:39
@aliu39 aliu39 merged commit bc5458e into master Aug 29, 2024
50 checks passed
@aliu39 aliu39 deleted the aliu/timestamp-queries-fix branch August 29, 2024 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants