fix(anomaly detection): surface validation error to user on trigger create/update #76643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
@nhsiehgit there should already be a test but I don't know where it is, so I'm waiting for it to fail (lol). If nothing fails, then I'll write new tests. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #76643 +/- ##
===========================================
+ Coverage 57.86% 78.15% +20.29%
===========================================
Files 6681 6910 +229
Lines 294458 307236 +12778
Branches 50667 50372 -295
===========================================
+ Hits 170393 240127 +69734
+ Misses 119386 60773 -58613
- Partials 4679 6336 +1657 |
ceorourke
reviewed
Aug 28, 2024
ceorourke
approved these changes
Aug 28, 2024
ArthurKnaus
pushed a commit
that referenced
this pull request
Aug 29, 2024
…reate/update (#76643) Missed a spot. When creating/updating triggers, catch form validation errors and surface them as serializer validation errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed a spot. When creating/updating triggers, catch form validation errors and surface them as serializer validation errors.