feat(replay): add mobile platforms to onboarding sidebar #76709
Conversation
github-actions
bot
added
the
Scope: Frontend
static/app/components/onboarding/gettingStartedDoc/utils/replayOnboarding.tsx
Outdated
Show resolved
Hide resolved
| Sentry.mobileReplayIntegration({ | ||
| maskAllText: true, | ||
| maskAllImages: true, | ||
| }), |
There was a problem hiding this comment.
These values are repeated in the configuration snippet, I would leave them out here since they are not needed and will make the init snipped a bit less overwhelming.
Also it will match the Browser JS which also by default doesn't show any config options.
| Sentry.mobileReplayIntegration({ | |
| maskAllText: true, | |
| maskAllImages: true, | |
| }), | |
| Sentry.mobileReplayIntegration(), |
There was a problem hiding this comment.
oh yes, good point -- i copied this from the docs so maybe we want to update it there too?
https://docs.sentry.io/platforms/react-native/session-replay/
There was a problem hiding this comment.
fixed here getsentry/sentry-docs#11192
|
In our other guides the |
|
Just a two small nits, otherwise RN looks good! |
yup, I can add that |
static/app/components/onboarding/gettingStartedDoc/utils/replayOnboarding.tsx
Outdated
Show resolved
Hide resolved
| import * as Sentry from '@sentry/react-native'; | ||
|
|
||
| Sentry.init({ | ||
| dsn = "${params.dsn.public}", |
There was a problem hiding this comment.
| dsn = "${params.dsn.public}", | |
| dsn: "${params.dsn.public}", |
There was a problem hiding this comment.
oh if this is the right syntax we should also update our docs, it's wrong there too https://docs.sentry.io/platforms/react-native/session-replay/
There was a problem hiding this comment.
Yes, this was an oversight in the docs, thank you for fixing it there as well.
| _experiments: { | ||
| replaysSessionSampleRate: 1.0, | ||
| replaysOnErrorSampleRate: 1.0, | ||
| }, |
There was a problem hiding this comment.
I'm not up to date on the RN sdk but should this still be in _experiments?
There was a problem hiding this comment.
that's how it is in our docs! https://docs.sentry.io/platforms/react-native/session-replay/
cc @krystofwoldrich👀
There was a problem hiding this comment.
Yes, _experiments is correct.
michellewzhang
requested review from
ArthurKnaus,
brustolin and
krystofwoldrich
| { | ||
| label: 'Kotlin', | ||
| value: 'kotlin', | ||
| language: 'java', |
There was a problem hiding this comment.
| language: 'java', | |
| language: 'kotlin', |
There was a problem hiding this comment.
ah okay, didn't know what was the standard since other onboardings use java for the language for kotlin
There was a problem hiding this comment.
updated those here: #76876
| options.isDebug = true | ||
|
|
||
| // Currently under experimental options: | ||
| options.experimental.sessionReplay.errorSampleRate = 1.0 |
There was a problem hiding this comment.
FYI: i've already merged the PR that changes the name to onErrorSampleRate - do we wanna wait for the new SDK release and change it now, or rather ship this and follow-up later?
There was a problem hiding this comment.
hmm @romtsn let's follow up perhaps, since we need to update the docs anyway - can do both at the same time. feel free to ping me to update when the SDK release is out
closes #67695
android:
Screen.Recording.2024-08-29.at.11.54.50.AM.mov
react native:
Screen.Recording.2024-08-29.at.11.55.57.AM.mov
apple:
Screen.Recording.2024-08-29.at.11.56.19.AM.mov