Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eap): Use new schema for the MQL EAP bridge #76714

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

colin-sentry
Copy link
Member

This standardizes things between graphing and samples in such a way that a lot of logic can be reused in snuba

@colin-sentry colin-sentry requested review from a team as code owners August 28, 2024 23:08
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 28, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ntry/sentry_metrics/querying/eap/mql_eap_bridge.py 12.50% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #76714       +/-   ##
===========================================
+ Coverage   57.32%   78.15%   +20.83%     
===========================================
  Files        6900     6910       +10     
  Lines      306805   307169      +364     
  Branches    50302    50347       +45     
===========================================
+ Hits       175863   240079    +64216     
+ Misses     126138    60739    -65399     
- Partials     4804     6351     +1547     

@colin-sentry colin-sentry merged commit d87aacd into master Aug 29, 2024
50 of 52 checks passed
@colin-sentry colin-sentry deleted the mql_eap_v2 branch August 29, 2024 19:34
mifu67 pushed a commit that referenced this pull request Sep 3, 2024
This standardizes things between graphing and samples in such a way that
a lot of logic can be reused in snuba
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants