chore(grouping): Stop calling _save_aggregate
#77838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
requested changes
Sep 20, 2024
| received_timestamp=job["received_timestamp"], | ||
| metric_tags=metric_tags, | ||
| ) | ||
| group_info = _save_aggregate_new( |
There was a problem hiding this comment.
Can we renamed it as part of this?
Okay - I was going to do it in stages and PR as I went, but lemme actually do all the steps and see how big it ends up being. I'll leave this open for now but won't merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #77027, all projects are using the new grouping config transition flow, because
project_uses_optimized_groupingnow always returnsTrue. We can therefore start removing the old code path.This takes the first step in that direction by removing the call to the old version of the
_save_aggregatefunction. Though this isn't strictly necessary before removing the function (since now no one should be going through the branch which calls it), this makes it extra obvious that nothing can go wrong when that happens.