Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): add view trends button to ai overview #78611

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

DominikB2014
Copy link
Contributor

Work for (#77572)
Similar to #78520

Adds a view trends button for the ai view and performs some related changes that were necessary for it to work
image

@DominikB2014 DominikB2014 requested a review from a team as a code owner October 4, 2024 15:06
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Bundle Report

Changes will increase total bundle size by 1.28kB (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 30.98MB 1.28kB (0.0%) ⬆️

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #78611       +/-   ##
===========================================
+ Coverage   52.16%   78.22%   +26.05%     
===========================================
  Files        7079     7104       +25     
  Lines      311665   312869     +1204     
  Branches    50904    51084      +180     
===========================================
+ Hits       162591   244729    +82138     
+ Misses     147549    61770    -85779     
- Partials     1525     6370     +4845     

Copy link
Member

@0Calories 0Calories left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to eventually have these trends buttons filter transactions based on the domain they were clicked from?

@DominikB2014
Copy link
Contributor Author

Are we going to eventually have these trends buttons filter transactions based on the domain they were clicked from?

Yup, if its possible, that's the plan. I think whatever filters are applied to the transaction table, will be applied once you click the view trends button.

@DominikB2014 DominikB2014 merged commit 508b223 into master Oct 18, 2024
44 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/view-trends-button-ai branch October 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants