Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unmerge): Add unmerge PUT endpoint #79122

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

jangjodi
Copy link
Member

@jangjodi jangjodi commented Oct 15, 2024

Unmerge endpoint is DELETE instead of PUT, causing it to use DELETE permissions
This is causing members to not have permission to unmerge issues

This PR adds the PUT endpoint, while keeping the DELETE endpoint until the FE call uses the new PUT endpoint
FE change: #79125

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/issues/endpoints/group_hashes.py 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #79122      +/-   ##
==========================================
+ Coverage   78.27%   78.30%   +0.02%     
==========================================
  Files        7137     7134       -3     
  Lines      314561   314310     -251     
  Branches    51359    51331      -28     
==========================================
- Hits       246226   246110     -116     
+ Misses      61885    61752     -133     
+ Partials     6450     6448       -2     

@jangjodi jangjodi marked this pull request as ready for review October 15, 2024 20:20
@jangjodi jangjodi requested review from a team as code owners October 15, 2024 20:20
@jangjodi jangjodi merged commit 078d193 into master Oct 18, 2024
49 of 50 checks passed
@jangjodi jangjodi deleted the jodi/member-unmerge-permission-be branch October 18, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants