Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(uptime): Remove uptime-rule-api flag #79138

Merged

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team October 15, 2024 18:58
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
21960 6 21954 216
View the top 3 failed tests by shortest run time
tests.sentry.incidents.endpoints.test_organization_combined_rule_index_endpoint.OrganizationCombinedRuleIndexEndpointTest test_name_filter
Stack Traces | 6.97s run time
#x1B[1m#x1B[.../incidents/endpoints/test_organization_combined_rule_index_endpoint.py#x1B[0m:798: in test_name_filter
    assert response.status_code == 200
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m
tests.sentry.incidents.endpoints.test_organization_combined_rule_index_endpoint.OrganizationCombinedRuleIndexEndpointTest test_uptime_feature_name_sort
Stack Traces | 7.18s run time
#x1B[1m#x1B[.../incidents/endpoints/test_organization_combined_rule_index_endpoint.py#x1B[0m:1095: in test_uptime_feature_name_sort
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Internal Error","errorId":null}'#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m
tests.sentry.incidents.endpoints.test_organization_combined_rule_index_endpoint.OrganizationCombinedRuleIndexEndpointTest test_filter_by_project
Stack Traces | 7.36s run time
#x1B[1m#x1B[.../incidents/endpoints/test_organization_combined_rule_index_endpoint.py#x1B[0m:454: in test_filter_by_project
    assert response.status_code == 200
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-uptime-remove-uptime-rule-api-flag branch from 6960bb3 to e59d06d Compare October 18, 2024 18:08
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) October 18, 2024 18:24
@evanpurkhiser evanpurkhiser merged commit 59a3c00 into master Oct 18, 2024
50 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-uptime-remove-uptime-rule-api-flag branch October 18, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants