Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): create screen rendering module #79192

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

DominikB2014
Copy link
Contributor

This PR adds a screen rendering module under the domain view.
image

This is a temporary change, the mobile screen module will require more work, but we can extract the screen rendering section of it as its own module in the meantime.

@DominikB2014 DominikB2014 requested a review from a team as a code owner October 16, 2024 16:39
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Bundle Report

Changes will increase total bundle size by 27.54kB (0.09%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 30.94MB 27.54kB (0.09%) ⬆️

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 20 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ile/screenRendering/screenRenderingLandingPage.tsx 0.00% 10 Missing ⚠️
...ile/screenRendering/screenRenderingSummaryPage.tsx 0.00% 6 Missing ⚠️
.../mobile/screenRendering/screenRenderingContent.tsx 0.00% 2 Missing ⚠️
...mobile/screens/components/screensOverviewTable.tsx 80.00% 1 Missing ⚠️
...mobile/ui/components/tables/spanOperationTable.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #79192      +/-   ##
==========================================
- Coverage   78.27%   78.27%   -0.01%     
==========================================
  Files        7137     7141       +4     
  Lines      314561   314596      +35     
  Branches    51359    51361       +2     
==========================================
+ Hits       246232   246248      +16     
- Misses      61883    61902      +19     
  Partials     6446     6446              

Copy link
Member

@mjq mjq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor text suggestion is all I've got, LGTM!

Co-authored-by: Matt Quinn <matt.quinn@sentry.io>
@DominikB2014 DominikB2014 enabled auto-merge (squash) October 18, 2024 20:38
@DominikB2014 DominikB2014 merged commit c3c7968 into master Oct 18, 2024
43 of 44 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/screen-recording-module branch October 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants