-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(insights): create screen rendering module #79192
Conversation
Bundle ReportChanges will increase total bundle size by 27.54kB (0.09%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79192 +/- ##
==========================================
- Coverage 78.27% 78.27% -0.01%
==========================================
Files 7137 7141 +4
Lines 314561 314596 +35
Branches 51359 51361 +2
==========================================
+ Hits 246232 246248 +16
- Misses 61883 61902 +19
Partials 6446 6446 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor text suggestion is all I've got, LGTM!
static/app/views/insights/common/components/modulesOnboarding.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Quinn <matt.quinn@sentry.io>
This PR adds a screen rendering module under the domain view.
This is a temporary change, the mobile screen module will require more work, but we can extract the screen rendering section of it as its own module in the meantime.