Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(py): Log to stderr not stdout #79235

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix(py): Log to stderr not stdout #79235

merged 1 commit into from
Oct 18, 2024
+8 −0

Conversation

evanpurkhiser
Copy link
Member

By default structlog is configured to write to stdout via it's default
PrintLogger. This change explicitly sets the PrintLogger to write to
stderr instead.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 16, 2024
asottile-sentry
asottile-sentry approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right thing to do -- should maybe double check in s4s that we're still ingesting logs properly

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/fix-py-log-to-stderr-not-stdout branch 2 times, most recently from ed35265 to 9459051 Compare October 18, 2024 18:07
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/fix-py-log-to-stderr-not-stdout branch from 9459051 to 0951550 Compare October 18, 2024 18:08
asottile-sentry
asottile-sentry approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanpurkhiser evanpurkhiser enabled auto-merge (squash) October 18, 2024 18:16
@evanpurkhiser evanpurkhiser merged commit f5e1789 into master Oct 18, 2024
50 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/fix-py-log-to-stderr-not-stdout branch October 18, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile-sentry asottile-sentry asottile-sentry approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @asottile-sentry