fix(feedback): enforce a max message size from all sources #79326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliu39
changed the title
github-actions
bot
added
the
Scope: Backend
aliu39
commented
Oct 17, 2024
| tags={ | ||
| "is_spam": is_message_spam, | ||
| "pow2_size_bucket": 2 ** math.ceil(math.log2(len(feedback_message))), |
There was a problem hiding this comment.
Limits the granularity of this tag. I'd rather do this for viewing in datadog, instead of logging each msg size.
There was a problem hiding this comment.
cant we just use a distribution metric type?
|
This PR has a migration; here is the generated SQL for --
-- Alter field comments on userreport
--
-- (no-op) |
… in one file + rename/comment
JoshFerge
reviewed
Oct 18, 2024
src/sentry/ingest/userreport.py
Outdated
| metrics.incr( | ||
| "feedback.large_message", | ||
| tags={ | ||
| "pow2_size_bucket": 2 ** math.ceil(math.log2(len(report["comments"]))), |
There was a problem hiding this comment.
same here. can we just make it a distribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76298
Closes SENTRY-3B86
Decided on a limit of 4096, generously below the LLM request, postgres, and kafka size limits described in the ticket. Messages that are too large will be truncated (or rejected, for crash report modal) and skip spam detection, auto-marking as spam.
Includes a small refactor of
create_feedback.py, moving stuff around and commenting a bit.Renamedauto_ignore_spam_feedbacktoset_feedback_ignored.