Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feedback): enforce a max message size from all sources #79326

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

fix(feedback): enforce a max message size from all sources #79326

wants to merge 12 commits into from
+234 −52

Commits on Oct 17, 2024

  1. Truncate large msgs in create_feedback and skip spam detection. +some… 

    … refactoring
    @aliu39
    aliu39 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6429272 View commit details
    Browse the repository at this point in the history

  2. Add create_feedback tests

    @aliu39
    aliu39 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    852f56a View commit details
    Browse the repository at this point in the history

  3. Add metric (with fancy tag)

    @aliu39
    aliu39 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    dfae0ea View commit details
    Browse the repository at this point in the history

  4. Rename size tag

    @aliu39
    aliu39 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    16ca14d View commit details
    Browse the repository at this point in the history

  5. Truncate in save_userreport

    @aliu39
    aliu39 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    54d97c8 View commit details
    Browse the repository at this point in the history

  6. Set length limit in crash report Form class

    @aliu39
    aliu39 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a325ab7 View commit details
    Browse the repository at this point in the history

  7. Add save_userreport and crash report form coverage

    @aliu39
    aliu39 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ab32aba View commit details
    Browse the repository at this point in the history

  8. Fix typing

    @aliu39
    aliu39 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6c54428 View commit details
    Browse the repository at this point in the history

  9. Make migration

    @aliu39
    aliu39 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b517c67 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Move auto_ignore_feedback back to create_feedback to keep kafka logic… 

    … in one file + rename/comment
    @aliu39
    aliu39 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9af5645 View commit details
    Browse the repository at this point in the history

  2. Revert name for auto_ignore_spam_feedbacks

    @aliu39
    aliu39 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    561c38e View commit details
    Browse the repository at this point in the history

  3. Use metrics.distribution

    @aliu39
    aliu39 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bf7b53a View commit details
    Browse the repository at this point in the history