Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issues): Avoid streamline issue layout rerenders #79327

Merged
merged 4 commits into from
Oct 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 43 additions & 20 deletions static/app/views/issueDetails/streamline/eventDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import {DatePageFilter} from 'sentry/components/organizations/datePageFilter';
import {EnvironmentPageFilter} from 'sentry/components/organizations/environmentPageFilter';
import {t} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import type {Event} from 'sentry/types/event';
import type {Group} from 'sentry/types/group';
import type {MultiSeriesEventsStats} from 'sentry/types/organization';
import {useIsStuck} from 'sentry/utils/useIsStuck';
import {useLocation} from 'sentry/utils/useLocation';
Expand All @@ -22,6 +24,7 @@ import {
} from 'sentry/views/issueDetails/groupEventDetails/groupEventDetailsContent';
import {
EventDetailsContext,
useEventDetails,
useEventDetailsReducer,
} from 'sentry/views/issueDetails/streamline/context';
import {EventGraph} from 'sentry/views/issueDetails/streamline/eventGraph';
Expand All @@ -44,14 +47,10 @@ export function EventDetails({
event,
project,
}: Required<EventDetailsContentProps>) {
const theme = useTheme();
const location = useLocation();
const navigate = useNavigate();
const {selection} = usePageFilters();
const isScreenMedium = useMedia(`(max-width: ${theme.breakpoints.medium})`);
const {environments} = selection;
const [nav, setNav] = useState<HTMLDivElement | null>(null);
const isStuck = useIsStuck(nav);
const {eventDetails, dispatch} = useEventDetailsReducer();

const searchQuery = useEventQuery({group});
Expand All @@ -70,15 +69,6 @@ export function EventDetails({
},
});

useLayoutEffect(() => {
const navHeight = nav?.offsetHeight ?? 0;
const sidebarHeight = isScreenMedium ? theme.sidebar.mobileHeightNumber : 0;
dispatch({
type: 'UPDATE_DETAILS',
state: {navScrollMargin: navHeight + sidebarHeight},
});
}, [nav, isScreenMedium, dispatch, theme.sidebar.mobileHeightNumber]);

return (
<EventDetailsContext.Provider value={{...eventDetails, dispatch}}>
<Feature features={['organizations:ai-summary']}>
Expand Down Expand Up @@ -135,13 +125,7 @@ export function EventDetails({
message={t('There was an error loading the event content')}
>
<GroupContent>
<FloatingEventNavigation
event={event}
group={group}
ref={setNav}
query={searchQuery}
data-stuck={isStuck}
/>
<StickyEventNav event={event} group={group} searchQuery={searchQuery} />
<ContentPadding>
<EventDetailsContent group={group} event={event} project={project} />
</ContentPadding>
Expand All @@ -159,6 +143,45 @@ export function EventDetails({
);
}

function StickyEventNav({
event,
group,
searchQuery,
}: {
event: Event;
group: Group;
searchQuery: string;
}) {
const theme = useTheme();
const [nav, setNav] = useState<HTMLDivElement | null>(null);
const isStuck = useIsStuck(nav);
const isScreenMedium = useMedia(`(max-width: ${theme.breakpoints.medium})`);
const {dispatch} = useEventDetails();

useLayoutEffect(() => {
if (!nav) {
return;
}

const navHeight = nav.offsetHeight ?? 0;
const sidebarHeight = isScreenMedium ? theme.sidebar.mobileHeightNumber : 0;
dispatch({
type: 'UPDATE_DETAILS',
state: {navScrollMargin: navHeight + sidebarHeight},
});
}, [nav, isScreenMedium, dispatch, theme.sidebar.mobileHeightNumber]);

return (
<FloatingEventNavigation
event={event}
group={group}
ref={setNav}
query={searchQuery}
data-stuck={isStuck}
/>
);
}

const SearchFilter = styled(EventSearch)`
border-radius: ${p => p.theme.borderRadius};
`;
Expand Down
Loading