Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issues): Add anchor links back to issue sections #79333

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Oct 17, 2024

clicking the link should add #tags to the url
refreshing the page or visiting the url should focus that component

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 17, 2024
to={{
...location,
hash: `#${config.key}`,
replace: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is replace the right choice

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind it, but I don't think the other one replaced did it?

@scttcper scttcper marked this pull request as ready for review October 18, 2024 21:13
@scttcper scttcper requested a review from a team as a code owner October 18, 2024 21:13
Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure how you can go about testing this. I guess just see if hash gets added, but the scroll logic might be harder

to={{
...location,
hash: `#${config.key}`,
replace: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind it, but I don't think the other one replaced did it?

@scttcper scttcper enabled auto-merge (squash) October 18, 2024 21:48
@scttcper scttcper merged commit 2c78700 into master Oct 18, 2024
43 of 44 checks passed
@scttcper scttcper deleted the scttcper/anchor-link-sections branch October 18, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants