-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issues): Add anchor links back to issue sections #79333
Conversation
to={{ | ||
...location, | ||
hash: `#${config.key}`, | ||
replace: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is replace the right choice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind it, but I don't think the other one replaced did it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure how you can go about testing this. I guess just see if hash gets added, but the scroll logic might be harder
to={{ | ||
...location, | ||
hash: `#${config.key}`, | ||
replace: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind it, but I don't think the other one replaced did it?
clicking the link should add #tags to the url
refreshing the page or visiting the url should focus that component