perf(issues): improve adjacent_events query #79365
Merged
+240
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
approved these changes
Oct 18, 2024
| Condition( | ||
| Column(DATASETS[dataset][Columns.TIMESTAMP.value.alias]), | ||
| Op.LT, | ||
| event.datetime + timedelta(days=100), |
There was a problem hiding this comment.
sentry/src/sentry/eventstore/snuba/backend.py
Line 577 in 55415ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the a
adjacent_eventsquery does a really big scan in order to find the adjacent events given an event id. It does this because the old query does not specify an order by which can take advantage of the primary keyORDER BY (project_id, toStartOfDay(timestamp), primary_hash, cityHash64(event_id))This PR adds a new function
get_adjacent_event_ids_snqlwhich uses SnQL and adds a order by clause. We observe in the snuba admin tool this new query takes only 2 seconds and scans hundreds of MBs of data as opposed to the old query which scans 10+ GB on large issues.get_adjacent_event_ids_snqlis not general purpose as its only used in one place.see ticket below for more info:
Fixes https://github.com/getsentry/team-issues/issues/42