ref(dashboards): Split dashboard warnings into components and hooks #79382
+194
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard widgets have various little badges and warnings. Each of them is its own component that loads its own data. This works fine, but is blocking a refactor I'm doing. In the very near future I don't want to use those little components, but I need to re-use their logic.
This PR takes each of those components and splits it into a hook that returns its state, and a component that consumes that state and renders the UI. This will make it easy for me to re-use that hook (and the components) and render a different UI.
Best enjoyed with whitespace turned off.