Skip to content

fix(trace): dont allow expanding and collapsing root node#79390

Merged
JonasBa merged 2 commits intomasterfrom
jb/trace/keyboard-nav-collapse
Oct 21, 2024
Merged

fix(trace): dont allow expanding and collapsing root node#79390
JonasBa merged 2 commits intomasterfrom
jb/trace/keyboard-nav-collapse

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Oct 18, 2024

Dont allow expanding or collapsing the trace root node and ensure we always render transaction children

@JonasBa JonasBa requested a review from a team October 18, 2024 23:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 18, 2024
@JonasBa JonasBa merged commit 6e69e91 into master Oct 21, 2024
@JonasBa JonasBa deleted the jb/trace/keyboard-nav-collapse branch October 21, 2024 16:23
@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ic/app/views/performance/newTraceDetails/trace.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #79390   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files        7132     7132           
  Lines      315164   315171    +7     
  Branches    51516    51519    +3     
=======================================
+ Hits       246894   246903    +9     
+ Misses      61805    61799    -6     
- Partials     6465     6469    +4     

kneeyo1 pushed a commit that referenced this pull request Oct 21, 2024
Dont allow expanding or collapsing the trace root node and ensure we
always render transaction children
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
Dont allow expanding or collapsing the trace root node and ensure we
always render transaction children
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants