deps(ui): Upgrade emotion #84259
Merged
deps(ui): Upgrade emotion #84259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didn't realize they had merged emotion-js/emotion#2815 which should give our tests that still use react-select a decent performance bump
github-actions
bot
added
the
Scope: Frontend
# Conflicts: # static/app/utils/withSavedSearches.tsx # static/app/utils/withTeamsForUser.tsx
ryan953
approved these changes
Feb 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unblocks part of react 19 https://github.com/getsentry/frontend-tsc/issues/68
Our HoC's that use generics to set prop types are hitting a bug in the emotion types emotion-js/emotion#3261 but we aren't really changing these very often or adding new ones.
tests using react-select see minor speed improvements (non scientific benchmark using github actions) because of emotion-js/emotion#2815 no longer creating error stacks on every render
before
widgetBuilder/widgetBuilderSortBy.spec.tsx (55.529 s)
alerts/create.spec.tsx (52.456 s)
after
widgetBuilder/widgetBuilderSortBy.spec.tsx (45.639 s)
alerts/create.spec.tsx (41.514 s)