Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AiGenerator functionality #47

Merged
merged 42 commits into from
Apr 19, 2024
Merged

AiGenerator functionality #47

merged 42 commits into from
Apr 19, 2024

Conversation

ChrisSimmons
Copy link
Member

No description provided.

ssterli2
ssterli2 previously approved these changes Apr 9, 2024
View reviewed changes
mapitman
mapitman requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@mapitman mapitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to resolve all of the warnings before merging this.

GettyImages.Api/AiGenerator/DownloadGeneratedImage.cs Outdated Show resolved Hide resolved
GettyImages.Api/PolledPathApiRequest.cs Show resolved Hide resolved
GettyImages.Api/HttpResponseMessageExtensions.cs Outdated Show resolved Hide resolved
GettyImages.Api/WebHelper.cs Show resolved Hide resolved
IntegrationTests/README.md Outdated Show resolved Hide resolved
@ChrisSimmons
Copy link
Member Author

It would be great to resolve all of the warnings before merging this.

Completely agree. I'm on it.

@ChrisSimmons ChrisSimmons marked this pull request as ready for review April 17, 2024 16:40
ChrisSimmons
ChrisSimmons commented Apr 17, 2024
View reviewed changes
Copy link
Member Author

@ChrisSimmons ChrisSimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes addressed

GettyImages.Api/AiGenerator/ImageGenerations.cs Outdated Show resolved Hide resolved
GettyImages.Api/AiGenerator/ImageGenerations.cs Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
GettyImages.Api/AiGenerator/DownloadGeneratedImage.cs Show resolved Hide resolved
GettyImages.Api/AiGenerator/DownloadGeneratedImage.cs Show resolved Hide resolved
GettyImages.Api/Models/ImageGenerationsSize.cs Show resolved Hide resolved
GettyImages.Api/HttpResponseMessageExtensions.cs Show resolved Hide resolved
IntegrationTests/AiGeneratorTests.cs Show resolved Hide resolved
IntegrationTests/README.md Outdated Show resolved Hide resolved
GettyImages.Api/AiGenerator/DownloadGeneratedImage.cs Outdated Show resolved Hide resolved
mapitman
mapitman approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@mapitman mapitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ChrisSimmons ChrisSimmons merged commit 4e0fd43 into main Apr 19, 2024
3 checks passed
@ChrisSimmons ChrisSimmons deleted the AiGenerator-endpoints branch April 19, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapitman mapitman mapitman approved these changes

@ssterli2 ssterli2 ssterli2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisSimmons @mapitman @ssterli2