Skip to content

Commit 0a3c78e

Browse files
committed
Fixed docker build and unittests
1 parent 937dba6 commit 0a3c78e

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ RUN apt-get update && apt-get install -y software-properties-common && \
2424
COPY Makefile /opt/rnaseqc/Makefile
2525
RUN cd /opt/rnaseqc && git clone --recursive https://github.com/walaj/SeqLib.git && \
2626
cd SeqLib && git checkout 7e1f98267b5057f9505dbff119308137a0e006db && cd .. && \
27-
make SeqLib/bin/libseqlib.a
27+
make SeqLib/lib/libseqlib.a
2828

2929
# python
3030
RUN cd /opt && git clone https://github.com/francois-a/rnaseq-utils rnaseq && cd rnaseq && \

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ SRCDIR=src
1717
OBJECTS=$(SOURCES:.cpp=.o)
1818
SEQFLAGS=$(STDLIB) -D_GLIBCXX_USE_CXX11_ABI=$(ABI)
1919

20-
rnaseqc: $(foreach file,$(OBJECTS),$(SRCDIR)/$(file)) SeqLib/bin/libseqlib.a SeqLib/bin/libhts.a
20+
rnaseqc: $(foreach file,$(OBJECTS),$(SRCDIR)/$(file)) SeqLib/lib/libseqlib.a SeqLib/lib/libhts.a
2121
$(CC) -O3 $(LIBRARY_PATHS) -o $@ $^ $(STATIC_LIBS) $(LIBS)
2222

2323
.PHONY: lib
@@ -28,7 +28,7 @@ lib: $(foreach file,$(OBJECTS),$(SRCDIR)/$(file))
2828
%.o: %.cpp
2929
$(CC) $(CFLAGS) -I. $(INCLUDE_DIRS) -c -o $@ $<
3030

31-
SeqLib/bin/libseqlib.a SeqLib/bin/libhts.a:
31+
SeqLib/lib/libseqlib.a SeqLib/lib/libhts.a:
3232
cd SeqLib && ./configure && make CXXFLAGS="$(SEQFLAGS)" && make install
3333

3434
.PHONY: clean

test_data/Makefile.linux

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ LIBRARY_PATHS=
55
#Set to 0 if you encounter linker errors regarding strings from the bamtools library
66
ABI=1
77
#Provide full paths here to .a archives for libraries which should be statically linked
8-
STATIC_LIBS=SeqLib/bin/libhts.a /usr/lib/x86_64-linux-gnu/libboost_filesystem.a /usr/lib/x86_64-linux-gnu/libboost_regex.a /usr/lib/x86_64-linux-gnu/libboost_system.a /usr/lib/x86_64-linux-gnu/libz.a /usr/lib/x86_64-linux-gnu/liblzma.a /usr/lib/x86_64-linux-gnu/libbz2.a /usr/lib/gcc/x86_64-linux-gnu/5.5.0/libstdc++.a
8+
STATIC_LIBS=SeqLib/lib/libhts.a /usr/lib/x86_64-linux-gnu/libboost_filesystem.a /usr/lib/x86_64-linux-gnu/libboost_regex.a /usr/lib/x86_64-linux-gnu/libboost_system.a /usr/lib/x86_64-linux-gnu/libz.a /usr/lib/x86_64-linux-gnu/liblzma.a /usr/lib/x86_64-linux-gnu/libbz2.a /usr/lib/gcc/x86_64-linux-gnu/5.5.0/libstdc++.a
99
#List of remaining libraries that will be dynamically linked
1010
LIBS=-lpthread
1111

@@ -16,13 +16,13 @@ SOURCES=BED.cpp Expression.cpp GTF.cpp RNASeQC.cpp Metrics.cpp Fasta.cpp BamRead
1616
SRCDIR=src
1717
OBJECTS=$(SOURCES:.cpp=.o)
1818

19-
rnaseqc: $(foreach file,$(OBJECTS),$(SRCDIR)/$(file)) SeqLib/bin/libseqlib.a SeqLib/bin/libhts.a
19+
rnaseqc: $(foreach file,$(OBJECTS),$(SRCDIR)/$(file)) SeqLib/lib/libseqlib.a SeqLib/lib/libhts.a
2020
$(CC) -static -static-libstdc++ -static-libgcc -O3 $(LIBRARY_PATHS) -o $@ $^ $(STATIC_LIBS) $(LIBS)
2121

2222
%.o: %.cpp
2323
$(CC) -static -static-libstdc++ -static-libgcc $(CFLAGS) -I. $(INCLUDE_DIRS) -c -o $@ $<
2424

25-
SeqLib/bin/libseqlib.a SeqLib/bin/libhts.a:
25+
SeqLib/lib/libseqlib.a SeqLib/lib/libhts.a:
2626
cd SeqLib && ./configure && make CXXFLAGS=$(STDLIB) && make install
2727

2828
.PHONY: clean

test_data/Makefile.osx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ LIBRARY_PATHS=
55
#Set to 0 if you encounter linker errors regarding strings from the bamtools library
66
ABI=1
77
#Provide full paths here to .a archives for libraries which should be statically linked
8-
STATIC_LIBS=/usr/local/lib/libboost_filesystem.a /usr/local/lib/libboost_regex.a /usr/local/lib/libboost_system.a $(ZLIB_PATH) SeqLib/bin/libhts.a $(LZMA_PATH) /usr/local/opt/bzip2/lib/libbz2.a
8+
STATIC_LIBS=/usr/local/lib/libboost_filesystem.a /usr/local/lib/libboost_regex.a /usr/local/lib/libboost_system.a $(ZLIB_PATH) SeqLib/lib/libhts.a $(LZMA_PATH) /usr/local/opt/bzip2/lib/libbz2.a
99
#List of remaining libraries that will be dynamically linked
1010
LIBS=
1111

@@ -16,13 +16,13 @@ SOURCES=BED.cpp Expression.cpp GTF.cpp RNASeQC.cpp Metrics.cpp Fasta.cpp BamRead
1616
SRCDIR=src
1717
OBJECTS=$(SOURCES:.cpp=.o)
1818

19-
rnaseqc: $(foreach file,$(OBJECTS),$(SRCDIR)/$(file)) SeqLib/bin/libseqlib.a SeqLib/bin/libhts.a
19+
rnaseqc: $(foreach file,$(OBJECTS),$(SRCDIR)/$(file)) SeqLib/lib/libseqlib.a SeqLib/lib/libhts.a
2020
$(CC) -O3 $(LIBRARY_PATHS) -o $@ $^ $(STATIC_LIBS) $(LIBS)
2121

2222
%.o: %.cpp
2323
$(CC) $(CFLAGS) -I. $(INCLUDE_DIRS) -c -o $@ $<
2424

25-
SeqLib/bin/libseqlib.a SeqLib/bin/libhts.a:
25+
SeqLib/lib/libseqlib.a SeqLib/lib/libhts.a:
2626
cd SeqLib && ./configure && make CXXFLAGS=$(STDLIB) && make install
2727

2828
.PHONY: clean

0 commit comments

Comments
 (0)