fix(gles): Only use sampler2DShadow if comparison samplers are used #8696
+104
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This seems to be a heuristic rather than something that would make depth textures work with both comparison and non-comparison samplers. We talked about this as part of the compat mode gpuweb/gpuweb#4970 and decided to disallow using depth textures with non-comparison samplers. Note that you can always bind a depth texture as a |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When declaring a texture_depth_2d in a shader, naga always outputs the texture uniform as type sampler2DShadow. When only interested in depth values and not comparisons, this breaks. This PR only uses sampler2DShadow when a comparison sampler is used for it. This is the only fix that I could come up with that only impacts the gles part.
This is a redo of closed PR #8301 , with fixed tests.