Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape user id following XMPP protocol specifications #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Escape user id following XMPP protocol specifications #28

wants to merge 3 commits into from

Conversation

vipod
Copy link

@vipod vipod commented Apr 17, 2012

In these commits we applied bunch of fixes to escape user ids, so that, for example, even email addresses will work for user ids. Actually this was our use case: make jarn.xmpp.* bundle work in plone with 'email as login' feature switched on.

We escape user ids both on server and client side. Escaping procedure was implemented according to XMPP protocol specifications.

@ggozad
Copy link
Owner

ggozad commented Apr 29, 2012

Awesome! I am happy to merge as is, would it be possible update changelogs, readme etc, including instructions and migrations if necessary for existing installations? I think since the storage is affected it might be necessary to provide an upgradeStep, if not let me know and I will cut a new release.

@vipod
Copy link
Author

vipod commented Apr 30, 2012

Okay, we'll get back to you once all above things are reviewed. Another thing I have to mention is that we were not able to make collaborative editing work properly on our installations, so completely disabled it and using only 'messaging' functionality. That's why the changes made in this pull request haven't been tested with collaborative editing. So this is one more thing we should probably check now.

@ggozad
Copy link
Owner

ggozad commented Apr 30, 2012

Thank you! Do not worry about j.x.collaboration. There have been changes in tinymce that completely break it anyway, so it is not an issue with your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants