Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Italian RPX files #137

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ugGit
Copy link

@ugGit ugGit commented Aug 22, 2023

This PR adds support for RPX files which were exported in Italian as suggested in issue #136. This extends the existing languages English, French, and German.

@ugGit
Copy link
Author

ugGit commented Aug 22, 2023

I think, it would be great to add another test case. However, I suspect that it might be good to aim for consistency with respect to the test files. Therefore, it would be great if @ghammad could probably generate the file in the same manner as the other RPX files used for tests.

Copy link
Owner

@ghammad ghammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghammad
Copy link
Owner

ghammad commented Oct 6, 2023

I think, it would be great to add another test case. However, I suspect that it might be good to aim for consistency with respect to the test files. Therefore, it would be great if @ghammad could probably generate the file in the same manner as the other RPX files used for tests.

@ugGit : could you send an Italian file example you use? In addition, we still need to figure out how "Mobility" and "S/W Status" are translated in Italian and include these translations in the dict.

@ugGit
Copy link
Author

ugGit commented Oct 16, 2023

Here you go for the file: example_it.csv

The thing with the Mobility and S/W Status is that they are not listed in the columns in my examples. The same already seem to have applied when somebody added support for the german language. Thus, I did not bother me too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants