Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix build with JS backend #134

Closed
wants to merge 1 commit into from

Conversation

hsyl20
Copy link
Contributor

@hsyl20 hsyl20 commented May 12, 2023

Fix the build with the JS backend.

Just here to avoid duplicating work.

Known issues:

  • don't fix any FFI import (GHCJS inline syntax isn't supported by the JS backend)
  • don't maintain backward compatibility
  • not tested

@hsyl20 hsyl20 marked this pull request as draft May 12, 2023 15:44
@alaendle
Copy link
Contributor

Many thanks for this draft, just out of curiosity I tried to make the test-suite pass (https://github.com/alaendle/ghcjs-base/tree/renovate) - however I have the feeling that this inevitable reveals all the current shortcomings (e.g. incomplete JavaScript support in text - haskell/text#536 - on this one I have stopped); and also the easy to mitigate haskellari/splitmix#75.
I think this comment is not a news for people directly involved, but maybe it's helpful to outsiders.

@hamishmack
Copy link
Member

Replaced by #135

@hamishmack hamishmack closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants