Merged
Conversation
boeschf
reviewed
Dec 19, 2024
Comment on lines
80
to
81
| auto device_handle() const noexcept { return m_data.m_device_handle; } | ||
| auto& device_handle() noexcept { return m_data.m_device_handle; } |
Collaborator
There was a problem hiding this comment.
why do we need to be able to change a device handle?
Collaborator
Author
There was a problem hiding this comment.
A very good question. We have a non const version of the host ptr handle ref as well and I added this access to fix a compilation error. But looking again at my code, I added a const to the use of the handle ref and now I do not need to non const access, so I will remove this. Might also be able to do the same with the host ptr handle ref ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a longstanding bug with gpu usage