Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose displayEmptyDataWarning #1521

Merged

Conversation

zewa666
Copy link
Contributor

@zewa666 zewa666 commented Feb 4, 2025

hey there, I'd like to expose this method publically as there are scenarios with the OData Backend where data loads aren't properly detected and I'd like to handle the message display by myself. So far this needs an ugly any cast in order to access.

Copy link

stackblitz bot commented Feb 4, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8f0a061) to head (4b917af).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1521   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1025      1025           
  Branches       386       386           
=========================================
  Hits          1025      1025           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 6bb197d into ghiscoding:master Feb 4, 2025
6 checks passed
@ghiscoding
Copy link
Owner

ok sure, that seems valid

@ghiscoding
Copy link
Owner

ghiscoding commented Feb 8, 2025

@zewa666 release is out, however it's now out of sync with version numbers (minor vs patch) since I didn't noticed this PR was a feat (minor) oops... not a problem, all we have to do is to add a new feature in Slickgrid-Universal and make a fix commit in here to resync it (and also rely on my memory to do that next time around, which might not happen if memory goes lol).

Always nice to get contributions, cheers 🚀

@zewa666
Copy link
Contributor Author

zewa666 commented Feb 8, 2025

I looked up a few examples and most implied a visibility change is seen as feat. wasnt sure about that either

@ghiscoding
Copy link
Owner

that's all good, I just like to keep versions around the same, it makes it easier to know which versions are compatible. Anyway, this will all go away once I merged all frameworks into Slickgrid-Universal, it will be 1 release for all, can't wait :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants