fix: column reordering shouldn't lose hidden columns, fixes #2432

[ghiscoding]

fixes #2432

after recent breaking change to use column hidden prop in v10.0, this introduced a regression describe in #2432 because I didn't have any E2E tests to reorder columns when there's 1 or more hidden columns.

The best option to remove the regression seems to be keeping a map of all columns and their hidden prop in the onStart callback of SortableJS (meaning, keep a map before moving anything) and then on the onEnd (when move is done) apply the reorder by looping through the map but keep the hidden ones at the same index position and now it seems to work as expected

TODOs

• fix regression
• add unit tests
• add Cypress E2E tests

[pkg-pr-new]

angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2433

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2433

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2433

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2433

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2433

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2433

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2433

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2433

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2433

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2433

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2433

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2433

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2433

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2433

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2433

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2433

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2433

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2433

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2433

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2433

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2433

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2433

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2433

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2433

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2433

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2433

commit: 579f7a9

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (f4c86c0) to head (635b93e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2433   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         196      196           
  Lines       24375    24386   +11     
  Branches     8543     8545    +2     
=======================================
+ Hits        24375    24386   +11     

Flag	Coverage Δ
angular	100.0% <ø> (ø)
universal	100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.