-
Notifications
You must be signed in to change notification settings - Fork 0
Sourcery refactored main branch #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| # create random data with name , age , income and IQ | ||
|
|
||
| names = ['name'+str(i) for i in range(100)] | ||
| names = [f'name{str(i)}' for i in range(100)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 7-7 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| hs = HandleStock(id=id) | ||
| res = hs.get_analysis() | ||
| return res | ||
| return hs.get_analysis() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function get_stock_detail refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| elif stock_industry in [1, 2, 3, 4]: | ||
| elif stock_industry in {1, 2, 3, 4}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function get_stock_with_query_params refactored with the following changes:
- Use set when checking membership of a collection of literals (
collection-into-set)
| response = {'max_price ': float(max_price), 'min_price': float(min_price), "last_10_day":last_10_days_price, 'start_date': float(start_date)} | ||
| return response | ||
| return { | ||
| 'max_price ': float(max_price), | ||
| 'min_price': float(min_price), | ||
| "last_10_day": last_10_days_price, | ||
| 'start_date': float(start_date), | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function HandleStock.get_analysis refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.02%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!