Add jitter window #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, if scheduled time was every hour, if a Cleaner instance was reconciled at 1:00:01, that Cleaner instance was not processed because reconciliation happened a second later than the scheduled one. If multiple Cleaner instances are all scheduled to be processed at the same time, this was causing problem with some Cleaner instances never processed. This PR introduces a window aroung the schedule time. By default this window is set to 15 seconds (though it is configurable using arg `jitter-window`). If reconciliation happens within jitter Window, a cleaner instance is still processed. To test this PR I created 8 Cleaner instances all scheduled at the same time: ```bash kubectl get cleaner -A NAME AGE completed-jobs 6m47s completed-pods 6m47s stale-persistent-volume-claim 6m47s unbound-peristent-volumes 6m47s unused-configmaps 6m47s unused-roles 6m47s unused-secrets 6m47s unused-service-accounts 6m46s ``` A report instance for each one of them was created ```bash kubectl get report -A NAME AGE completed-jobs 4m57s completed-pods 4m58s stale-persistent-volume-claim 4m58s unbound-peristent-volumes 4m58s unused-configmaps 4m57s unused-roles 4m57s unused-secrets 4m58s unused-service-accounts 4m58s ```
gianlucam76
force-pushed
the
jitter-window
branch
from
d5eaeb7 to
51c9ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if scheduled time was every hour, if a Cleaner instance was reconciled at 1:00:01, that Cleaner instance was not processed because reconciliation happened a second later than the scheduled one.
If multiple Cleaner instances are all scheduled to be processed at the same time, this was causing problem with some Cleaner instances never processed.
This PR introduces a window aroung the schedule time. By default this window is set to 15 seconds (though it is configurable using arg
jitter-window). If reconciliation happens within jitter Window, a cleaner instance is still processed.To test this PR I created 8 Cleaner instances all scheduled at the same time:
A report instance for each one of them was created
Fixes #80