✨ Add non root volumes to AWSMachineTemplate#591
Merged
mnitchev merged 1 commit intorelease-2.3from Apr 25, 2024
Merged
Conversation
mnitchev
changed the title
calvix
reviewed
Apr 25, 2024
| blockDeviceMappings = append(blockDeviceMappings, blockDeviceMapping) | ||
| } | ||
|
|
||
| if len(blockDeviceMappings) > 0 { |
There was a problem hiding this comment.
I feel like this will never be zero as you always at least append the root volume, but I guess it does no break anything to have this condition here
Author
There was a problem hiding this comment.
The root volume field is marked as optional, which is why I added this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/27903