✨ Support setting maxHealthyPercentage to configure ASG instance refresh #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiunchinho
force-pushed
the
support-maxhealthypercentage-fork
branch
from
893c671 to
a37d7b0
Compare
fiunchinho
force-pushed
the
support-maxhealthypercentage-fork
branch
from
a37d7b0 to
94c30f3
Compare
fiunchinho
commented
Oct 15, 2024
| @@ -888,6 +887,89 @@ spec: | |||
| description: Ignition defined options related to the bootstrapping | |||
| systems where Ignition is used. | |||
| properties: | |||
| proxy: | |||
There was a problem hiding this comment.
I'm not sure where this is coming from. Maybe we (I probably) forgot to run make generate in the past?
mnitchev
approved these changes
Oct 15, 2024
| @@ -153,6 +153,27 @@ func TestAWSMachinePoolValidateCreate(t *testing.T) { | |||
| }, | |||
| wantErr: true, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Maybe a test for when the value is above 200?
There was a problem hiding this comment.
This is just cherry picking from upstream, so I'd prefer not to change the tests just in the fork.
fiunchinho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/31305
Backport of kubernetes-sigs#5140