Apply our customizations on top of upstream release-2.7 #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, also include giantswarm/cluster-api-provider-aws-app#272 |
AndiDog
force-pushed
the
upgrade-release-2-7
branch
from
fbf28fb to
5cad8d3
Compare
AndiDog
force-pushed
the
upgrade-release-2-7
branch
from
5cad8d3 to
c32be24
Compare
fiunchinho
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/32021
I pushed the latest
upstream/release-2.7as our fork'srelease-2.7branch. This PR adds our fork changes on top. Seems that only the S3 Ignition support must be added and everything else is contained in v2.7.x already (judging from the commits in our previous release-2.5 upgrade PR, as also listed incluster-api-provider-aws-app/helm/cluster-api-provider-aws/values.yaml).(Not tested yet at time of PR creation, but will be soon.)