Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-generated docs. #425

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Re-generated docs. #425

merged 3 commits into from
Nov 21, 2023

Conversation

weseven
Copy link
Contributor

@weseven weseven commented Nov 20, 2023

What this PR does / why we need it

Checklist

  • Update changelog in CHANGELOG.md.

Trigger e2e tests

/run cluster-test-suites

@weseven weseven marked this pull request as ready for review November 21, 2023 11:26
@weseven weseven requested a review from a team as a code owner November 21, 2023 11:26
@calvix
Copy link
Contributor

calvix commented Nov 21, 2023

JSON schema validation / Verify values.schema.json with schemalint (push) still fails is that expected?

@nprokopic
Copy link
Contributor

JSON schema validation / Verify values.schema.json with schemalint (push) still fails is that expected?

This is the error:

Either global or root-level property must be present (both are not allowed)
  - /metadata

Which happens because there is both .Values.global.metadata (new schema) and .Values.metadata old schema, so the lint fails, because it does not let to mix old and new schemas (the Helm values schema should be either migrated or not).

That error will go away when I merge this PR #413 (and all other related PRs), which should happen later today.

@weseven weseven added the skip/ci Instructs PR Gatekeeper to ignore any required PR checks label Nov 21, 2023
@weseven weseven merged commit 4abba7d into master Nov 21, 2023
10 of 11 checks passed
@weseven weseven deleted the fix-missing-docs branch November 21, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/ci Instructs PR Gatekeeper to ignore any required PR checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants