Fix VPC policy in CAPA controller role CloudFormation template #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiunchinho
previously approved these changes
Nov 12, 2024
We hit the 10240 bytes limit for inline policies in an IAM role, so we better use managed policies instead Also renamed the capa controller VPC policy to match the other policies name pattern
iuriaranda
dismissed
fiunchinho’s stale review
made significant changes to the PR
|
I've refactored the CloudFormation template to use managed policies instead of inline, since we were hitting the 10240 bytes limit for inline policies with my recent changes (we were probably hitting that limit already with some installation names). For reference, the I've also tested an upgrade of the CF stack from inline to managed policies and it works as expected. |
fiunchinho
requested changes
Nov 12, 2024
fiunchinho
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/32065
Turns out that with the split-out policy, we're now over the 10240 bytes limit for inline policies 😕
So even though this fixes the CF template, it's still not usable... I guess the solution would be to refactor it completely to use managed policies, but not sure if it's possible in CF.
Checklist