Refactor AWS account setup #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found that importing existing resources into CF might be problematic, so migrating existing setups will be difficult Instead we choose to use standalone TF resources with the corresponding import blocks.
Different AWS partitions use completely different AWS credentials sets, so it would make sense to separate them in different tofu runs / workspaces, so we can still apply to one partition even if we don't have credentials for the other.
Both inline and managed policies can be added
From this warning: ╷ │ Warning: Additional provider information from registry │ │ The remote registry returned warnings for │ registry.opentofu.org/opentofu/aws: │ - You are using opentofu/aws instead of hashicorp/aws. This provider is │ maintained by HashiCorp and the OpenTofu project only builds the provider │ binaries from the source code. Both the opentofu/ and hashicorp/ namespaces │ in the OpenTofu Registry contain the OpenTofu-built provider binaries based │ on the HashiCorp source code. To avoid configuration errors, we recommend │ using the hashicorp/ namespaced providers. ╵
Also update the docs
AndiDog
reviewed
Jan 3, 2025
AndiDog
approved these changes
Jan 3, 2025
AndiDog
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a full refactor of the setup for our AWS account requirements setup. Spawned from the last hackathon.
Checklist