Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capa-controller-add-delete-volume-permission #94

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

calvix
Copy link
Contributor

@calvix calvix commented Apr 24, 2024

@calvix calvix self-assigned this Apr 24, 2024
@calvix calvix requested a review from a team as a code owner April 24, 2024 14:15
CHANGELOG.md Outdated Show resolved Hide resolved
@calvix calvix requested a review from AndiDog April 25, 2024 08:21
@calvix calvix assigned AndiDog and unassigned calvix Apr 25, 2024
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks cleaner like this 😉.

You still need to adapt giantswarm-capa-role.tf, though.

calvix added 2 commits April 25, 2024 14:00
….com:giantswarm/giantswarm-aws-account-prerequisites into capa-controller-add-delete-volume-permission
@calvix calvix merged commit 901c3b4 into master Apr 25, 2024
1 check passed
@calvix calvix deleted the capa-controller-add-delete-volume-permission branch April 25, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants