Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPA: Add hidden flags --aws-prefix-list-id and --aws-transit-gateway-id for private clusters #1029

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Feb 28, 2023

What does this PR do?

Add necessary flags to create workload clusters on private CAPA MCs. Also, validate related inputs (topology mode, TGW/PL ID format).

What is the effect of this change to users?

We omit the fields if not specified, so no changes.

What does it look like?

apiVersion: v1
data:
  values: |
    # [...]
    network:
      apiMode: private
      availabilityZoneUsageLimit: 3
      dnsMode: private
      prefixListID: pl-abcdef123456
      # [...]
      topologyMode: UserManaged
      transitGatewayID: tgw-123456ghijkl
      vpcCIDR: 1.2.3.0/22
      vpcMode: private
    # [...]
kind: ConfigMap
metadata:
  creationTimestamp: null
  labels:
    giantswarm.io/cluster: andreas36
  name: andreas36-userconfig
  namespace: org-giantswarm

Any background context you can provide?

Needed for testing giantswarm/roadmap#1832 on private clusters.

What is needed from the reviewers?

@giantswarm/team-hydra please check thoroughly if the flag help text matches what we actually do topology-wise. I've explained it as I understand the networking right now.

Do the docs need to be updated?

Not yet. We will do that together with private cluster feature documentation.

Should this change be mentioned in the release notes?

  • CHANGELOG.md has been updated

Is this a breaking change?

No

@AndiDog AndiDog requested review from a team February 28, 2023 11:09
@AndiDog AndiDog merged commit 4eaef99 into main Feb 28, 2023
@AndiDog AndiDog deleted the private-cluster-topology branch February 28, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants