This repository was archived by the owner on Apr 12, 2023. It is now read-only.
Small changes for install chart on kebernetes 1.11 #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
suggested changes
Jan 30, 2019
| ## This allows the prometheus-server to be run with an arbitrary user | ||
| ## | ||
| enabled: true | ||
| enabled: false |
Contributor
There was a problem hiding this comment.
Yeah I would like to default everything to enable, you can always customize your values and use them in the installation command.
helm install -f myvalues.yaml
| @@ -1,4 +1,4 @@ | |||
| piVersion: v1 | |||
| apiVersion: v1 | |||
| - https://github.com/prometheus/prometheus | ||
| tillerVersion: ">=2.8.0" | ||
| version: 0.1.0-[[ .SHA ]] | ||
| version: 0.1.0 |
pipo02mix
suggested changes
Jan 31, 2019
Contributor
pipo02mix
left a comment
pipo02mix
left a comment
There was a problem hiding this comment.
Good improvements. A couple of comments, please take a look
| @@ -1,4 +1,4 @@ | |||
| piVersion: v1 | |||
| apiVersion: v1 | |||
| ## This allows the prometheus-server to be run with an arbitrary user | ||
| ## | ||
| enabled: true | ||
| enabled: false |
Contributor
There was a problem hiding this comment.
Yeah I would like to default everything to enable, you can always customize your values and use them in the installation command.
helm install -f myvalues.yaml
Yea... It's was mistake... Co-Authored-By: ozlevka-ericom <lev.ozeryansky@ericom.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I make some small changes in chart and success to install on k8s 1.11.
If these changes important you welcome to merge my work to your master