Skip to content

sort out atlas images #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 23, 2023
Merged

sort out atlas images #941

merged 7 commits into from
Nov 23, 2023

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Nov 22, 2023 •
edited
Loading

Towards giantswarm/roadmap#2913

Currently missing fluent bit images but the rest should be sorted

@QuentinBisson QuentinBisson requested a review from a team November 22, 2023 15:24
@QuentinBisson QuentinBisson self-assigned this Nov 22, 2023
@QuentinBisson QuentinBisson requested a review from a team as a code owner November 22, 2023 15:25
@QuentinBisson QuentinBisson mentioned this pull request Nov 22, 2023
Closed
2 tasks
QuantumEnigmaa
QuantumEnigmaa reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a lot of difference with what I have :)
On my side I also have promxy and vpa because I wasn't sure it was up to us or not anymore

QuentinBisson and others added 3 commits November 22, 2023 17:21
@QuentinBisson @QuantumEnigmaa
Update images/skopeo-quay-io.yaml
3c4e700 
Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
@QuentinBisson @QuantumEnigmaa
Update images/skopeo-docker-io.yaml
ca0ebb5 
Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
@QuentinBisson @QuantumEnigmaa
Update images/skopeo-docker-io.yaml
c665911 
Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
@QuentinBisson
Copy link
Contributor Author

I'll check fluent bits tomorrow

QuentinBisson and others added 2 commits November 22, 2023 17:25
@QuentinBisson @QuantumEnigmaa
Update images/skopeo-docker-io.yaml
62b184b 
Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
@QuentinBisson
revert change for k8s-sidecar
f9ed5c4 
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuantumEnigmaa
QuantumEnigmaa approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson
Copy link
Contributor Author

Thank you @QuantumEnigmaa for the double check :)

@QuentinBisson QuentinBisson enabled auto-merge (squash) November 23, 2023 10:38
@QuentinBisson QuentinBisson merged commit d527026 into main Nov 23, 2023
@QuentinBisson QuentinBisson deleted the sort-atlas-images branch November 23, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumEnigmaa QuantumEnigmaa QuantumEnigmaa approved these changes

Assignees

@QuentinBisson QuentinBisson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuentinBisson @QuantumEnigmaa