WIP: Flight with arrow #30
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the FlightSQL server to use Arrow streaming by introducing a QueryArrow stub, refactoring ticket handling, and updating tests and dependencies to align with the latest Arrow client API.
- Added
QueryArrowstub toQueryClientand imported Arrow packages - Refactored
FlightSQLServerto encode tickets as base64 and callQueryArrowinDoGet - Replaced legacy
convertResultsToArrowtests with a basic FlightSQL server connection test - Updated
go.modto pull in new Arrow and other module versions
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| querier/queryClient.go | Added Arrow imports and unimplemented QueryArrow method stub |
| querier/flightsql.go | Removed in-memory storage, refactored GetFlightInfo/DoGet to use QueryArrow and base64 tickets |
| querier/flightsql_test.go | Dropped old conversion tests, added server startup helper and connection test |
| go.mod | Added/moved Arrow modules and bumped several indirect dependencies |
Comments suppressed due to low confidence (1)
querier/flightsql_test.go:31
- There is no
Initializemethod onQueryClient; this will cause a compilation error. Use the correct initialization method or implementInitializeonQueryClient.
_ = qc.Initialize()
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs resync w/ latest arrow